Automatically show English website for if browser is English #1659
Closed
david-jones10 wants to merge 3 commits intosigndict:mainfrom
david-jones10:main
Closed
Automatically show English website for if browser is English #1659david-jones10 wants to merge 3 commits intosigndict:mainfrom david-jones10:main
david-jones10 wants to merge 3 commits intosigndict:mainfrom
david-jones10:main
Conversation
Browser language is sent in request headers under Accept-Language. This change connects to the Plug.Accepts plug to allow the app to parse the Accepts headers, including the Accept-Language header. This will then give access to this information where the app decides which language to serve, to make a more accurate decision.
Updates get_user_locale to attempt to get locale from the HTTP request headers. If not, falls back to existing behaviour of attempting to read from conn object, finally returning nothing if none found.
connect to Plug.Accepts to access Accept-Language
Member
|
@david-jones10 thanks for this PR. It would be awesome if you add a test for this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing #228.
Hi @bitboxer ,
This MR offers a proposed solution to the above linked ticket.
It connects to the plug Plug.Accepts to access accept-language from the HTTP request headers when fetching the page. Then, it updates
get_user_localeto attempt to read from the headers. If this fails, it falls back to the existing behaviour for fetching from user definition.Please do test this thoroughly as I had some issues when running SignDict locally. I don't believe they were related to the changes, but as the owner I expect you'll have better luck running the environment fully compared to me!
Please let me know if there's any issues/changes you'd like to see.
Best,
David